Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin details modal using Vue #22055

Merged
merged 31 commits into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
6605dbe
Add translations
michalkleiner Mar 27, 2024
5d9d5df
Pass 'has some admin access' down to components
michalkleiner Mar 27, 2024
f06173f
Allow CTA container to optionally only display relevant actions (and …
michalkleiner Mar 27, 2024
cb4a1b8
Pass number of users down to view components
michalkleiner Mar 27, 2024
d07361b
Reimplement plugin details modal in Vue
michalkleiner Mar 27, 2024
6298eb6
Use MissingReqsNotice component directly
michalkleiner Mar 27, 2024
057212f
Remove crypto dependency as simpler mechanism can be used
michalkleiner Mar 28, 2024
808f298
Add target blank to content links
michalkleiner Mar 28, 2024
1d80ff6
Fix getting latest version mechanism to prevent tabs breaking
michalkleiner Mar 28, 2024
3f4d3b7
Use root reference when filtering for matching elements inside setTim…
michalkleiner Mar 28, 2024
9d3983a
Add types
michalkleiner Mar 28, 2024
34ec368
Hide More details button from plugin CTA when displayed in modal
michalkleiner Apr 23, 2024
ed000c6
Implement plugin details modal redesign
michalkleiner Apr 23, 2024
684ec23
Make links from URLs and emails in the extra support information
michalkleiner Apr 23, 2024
da4c11b
Remove unused computed property
michalkleiner Apr 23, 2024
38ff162
Fix license spelling in variable and method names
michalkleiner Apr 23, 2024
157a35f
Remove number of users from Marketplace as product variant selection …
michalkleiner Apr 23, 2024
92eac95
Add email validity check to author information section
michalkleiner Apr 23, 2024
4082407
Rearrange code to remove some of the max line length lint exceptions
michalkleiner Apr 23, 2024
741f80e
Move component state definition to the component file
michalkleiner Apr 23, 2024
89c15d8
Unify email sanitisation for author and supporting metadata
michalkleiner Apr 23, 2024
3b67f1f
Add types for iframeResizer
michalkleiner Apr 24, 2024
1b322ab
Merge HelpLink and MoreDetailsButton components into MoreDetailsAction
michalkleiner Apr 24, 2024
613f229
Adjust action links within CTA container to only appear when not pres…
michalkleiner Apr 24, 2024
5ad4c64
Improve responsive behaviour on smaller screens
michalkleiner Apr 24, 2024
40241d6
Ensure there's no empty text in CTA link actions
michalkleiner Apr 24, 2024
c98d1e9
Update dist files
michalkleiner Apr 24, 2024
6af9966
Remove "min-height" to prevent huge modals on huge screens
mneudert Apr 25, 2024
dd3e9c6
Update selectors for marketplace UI modal tests
mneudert Apr 25, 2024
51e6265
Keep minimal UI tests for old modal
mneudert Apr 25, 2024
5f1df8f
Update expected screenshots
mneudert Apr 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"vue": "^3.2.6"
},
"devDependencies": {
"@types/iframe-resizer": "^3.5.13",
"@types/jest": "^26.0.24",
"@types/materialize-css": "^1.0.11",
"@types/mousetrap": "^1.6.8",
Expand Down
26 changes: 26 additions & 0 deletions plugins/Marketplace/Marketplace.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public function getClientSideTranslationKeys(&$translationKeys)
$translationKeys[] = 'CorePluginsAdmin_ThemesDescription';
$translationKeys[] = 'CorePluginsAdmin_ViewAllMarketplacePlugins';
$translationKeys[] = 'CoreUpdater_UpdateTitle';
$translationKeys[] = 'General_Documentation';
$translationKeys[] = 'General_Download';
$translationKeys[] = 'General_Downloads';
$translationKeys[] = 'General_Help';
Expand Down Expand Up @@ -154,6 +155,31 @@ public function getClientSideTranslationKeys(&$translationKeys)
$translationKeys[] = 'Marketplace_UploadZipFile';
$translationKeys[] = 'Marketplace_ViewSubscriptions';
$translationKeys[] = 'Mobile_LoadingReport';
$translationKeys[] = 'Marketplace_AddToCart';
$translationKeys[] = 'Marketplace_Authors';
$translationKeys[] = 'Marketplace_AutoUpdateDisabledWarning';
$translationKeys[] = 'Marketplace_ByXDevelopers';
$translationKeys[] = 'Marketplace_ClickToCompletePurchase';
$translationKeys[] = 'Marketplace_CurrentNumPiwikUsers';
$translationKeys[] = 'Marketplace_Developer';
$translationKeys[] = 'Marketplace_FeaturedPlugin';
$translationKeys[] = 'Marketplace_LastCommitTime';
$translationKeys[] = 'Marketplace_LastUpdated';
$translationKeys[] = 'Marketplace_License';
$translationKeys[] = 'Marketplace_MultiServerEnvironmentWarning';
$translationKeys[] = 'Marketplace_NumDownloadsLatestVersion';
$translationKeys[] = 'Marketplace_PluginKeywords';
$translationKeys[] = 'Marketplace_PluginLicenseExceededDescription';
$translationKeys[] = 'Marketplace_PluginLicenseMissingDescription';
$translationKeys[] = 'Marketplace_PluginWebsite';
$translationKeys[] = 'Marketplace_PriceExclTax';
$translationKeys[] = 'Marketplace_Reviews';
$translationKeys[] = 'Marketplace_Screenshots';
$translationKeys[] = 'Marketplace_ShownPriceIsExclTax';
$translationKeys[] = 'Marketplace_TryFreeTrialTitle';
$translationKeys[] = 'CorePluginsAdmin_Activity';
$translationKeys[] = 'CorePluginsAdmin_Version';
$translationKeys[] = 'CorePluginsAdmin_Websites';
}

/**
Expand Down
3 changes: 3 additions & 0 deletions plugins/Marketplace/images/divider.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions plugins/Marketplace/images/star.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions plugins/Marketplace/stylesheets/marketplace.less
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@
.footer-message {
margin-top: 30px;
}

.modal {
background-color: #fff;
mneudert marked this conversation as resolved.
Show resolved Hide resolved
}
}


Expand Down
Loading
Loading