Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reminder to update TagManager when adding new JS tracker configs #21659

Merged
merged 1 commit into from
Dec 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/piwik.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
/*global unescape */
/*global ActiveXObject */
/*global Blob */
/* NOTE: If you add a new config setting to the tracker, like disableCookies, please add it to plugins/TagManager/Template/Tag/MatomoTag.web.js as well */
/*members Piwik, Matomo, encodeURIComponent, decodeURIComponent, getElementsByTagName,
shift, unshift, piwikAsyncInit, matomoAsyncInit, matomoPluginAsyncInit , frameElement, self, hasFocus,
createElement, appendChild, characterSet, charset, all, piwik_log, AnalyticsTracker,
Expand Down Expand Up @@ -6004,7 +6005,7 @@ if (typeof window.Matomo !== 'object') {
* Returns the PageView id. If the id was manually set using setPageViewId(), that id will be returned.
* If the id was not set manually, the id that was automatically generated in last trackPageView() will be
* returned. If there was no last page view, this will be undefined.
*
*
* @returns {string}
*/
this.getPageViewId = function () {
Expand Down
Loading