Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply max execution time limit to goals live query #21625

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Apply max execution time limit to goals live query #21625

merged 2 commits into from
Dec 7, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 1, 2023

Description:

fixes #21624

Review

@sgiehl sgiehl added the c: Performance For when we could improve the performance / speed of Matomo. label Dec 1, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Dec 1, 2023
@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 1, 2023
@sgiehl sgiehl marked this pull request as ready for review December 1, 2023 12:58
@sgiehl sgiehl requested a review from a team December 1, 2023 12:58
@bx80 bx80 merged commit d81f28b into 5.x-dev Dec 7, 2023
21 of 25 checks passed
@bx80 bx80 deleted the m21624 branch December 7, 2023 20:11
@sgiehl sgiehl modified the milestones: 5.0.0, 5.0.1 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

@bx80 bx80 bx80 approved these changes

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. Needs Review PRs that need a code review
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

[Bug] Goals/VisitorDetaisl::queryGoalConversionsForVisits() does not apply Live max execution time setting
4 participants
@sgiehl @michalkleiner @mneudert @bx80