Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jqplot rendering for some currency formats #21614

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix jqplot rendering for some currency formats #21614

merged 1 commit into from
Nov 30, 2023

Conversation

mneudert
Copy link
Member

Description:

The improved tick formatting introduced in #19353 can result in some currencies being detected as percentages. For example the formatting string kr%s (danish/swedish krona) is detected as a percentage and breaks the Y-Axis tick calculation.

Fixes #21612.

Review

@mneudert mneudert added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 30, 2023
@mneudert mneudert added this to the 5.0.0 milestone Nov 30, 2023
@mneudert mneudert added the Needs Review PRs that need a code review label Nov 30, 2023
@mneudert mneudert marked this pull request as ready for review November 30, 2023 14:07
sgiehl
sgiehl approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. I guess browser support for String.endsWith() should be good enough and match the browsers we aim to be compatible with - at least for the UI.

@sgiehl sgiehl merged commit ac22bff into 5.x-dev Nov 30, 2023
19 of 25 checks passed
@sgiehl sgiehl deleted the m21612 branch November 30, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Ecommece Overview revenue chart broken with change from SEK -> KR
2 participants
@mneudert @sgiehl