Fix problem with metric formatting in cloud visualization

[sgiehl]

Description:

Changing the requestConfig after the datatable was requested shouldn't be done. We therefor even trigger a warning here:

matomo/core/Plugin/Visualization.php

Lines 837 to 870 in b855509

	private function logMessageIfRequestPropertiesHaveChanged(array $requestPropertiesBefore)
	{
	$requestProperties = $this->requestConfig->getProperties();
	$diff = array_diff_assoc($this->makeSureArrayContainsOnlyStrings($requestProperties),
	$this->makeSureArrayContainsOnlyStrings($requestPropertiesBefore));
	if (!empty($diff['filter_sort_column'])) {
	// this here might be ok as it can be changed after data loaded but before filters applied
	unset($diff['filter_sort_column']);
	}
	if (!empty($diff['filter_sort_order'])) {
	// this here might be ok as it can be changed after data loaded but before filters applied
	unset($diff['filter_sort_order']);
	}
	if (empty($diff)) {
	return;
	}
	$details = array(
	'changedProperties' => $diff,
	'apiMethod' => $this->requestConfig->apiMethodToRequestDataTable,
	'controller' => $this->config->controllerName . '.' . $this->config->controllerAction,
	'viewDataTable' => static::getViewDataTableId()
	);
	$message = 'Some ViewDataTable::requestConfig properties have changed after requesting the data table. '
	. 'That means the changed values had probably no effect. For instance in beforeRender() hook. '
	. 'Probably a bug? Details:'
	. print_r($details, 1);
	Log::warning($message);
	}

This is currently done in the cloud visualization to handle problems with formatted/unformatted values.

To reproduce the issue you can simply go the Behaviour > Engagement. Two reports should by default be loaded as Cloud Viz. Rendering them should show the warning message in the logs.

This should also fix random UI test failures like https://builds-artifacts.matomo.org/matomo-org/matomo/5.x-dev/6982498243/UIIntegrationTest_visitors_realtime_visits.png

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[bx80]

Looks good to me 👍