Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special sanitizing of {{ #21596

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Remove special sanitizing of {{ #21596

merged 1 commit into from
Nov 24, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 24, 2023

Description:

The special handling of sanitizing {{ was added while we were using Angular JS due to security reasons.
Angular was interpreting variables placed within html, which could cause issues in some cases.

As we meanwhile fully removed Angular JS, and Vue.JS doesn't have issues around that, we can remove the special handling again.

fixes #21594

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 24, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 24, 2023
@sgiehl sgiehl requested a review from a team November 24, 2023 14:29
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 24, 2023
@sgiehl sgiehl merged commit fce6a2e into 5.x-dev Nov 24, 2023
22 of 25 checks passed
@sgiehl sgiehl deleted the fixsanitize branch November 24, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] No Data screen for SPAs contains hidden space in variables
2 participants