Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make feature gates individually dismissible per user (4 Backport) #21590

Merged
merged 20 commits into from
Nov 23, 2023
Merged

Make feature gates individually dismissible per user (4 Backport) #21590

merged 20 commits into from
Nov 23, 2023

Conversation

caddoo
Copy link
Contributor

@caddoo caddoo commented Nov 23, 2023

Description:

Matomo 4 version of: #21587

Review

@caddoo caddoo marked this pull request as ready for review November 23, 2023 06:51
@caddoo caddoo added the Needs Review PRs that need a code review label Nov 23, 2023
@caddoo caddoo requested a review from sgiehl November 23, 2023 06:52
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 23, 2023
@sgiehl sgiehl added this to the 4.16.0 milestone Nov 23, 2023
sgiehl
sgiehl approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected now and tests are passing

@sgiehl sgiehl merged commit 927fbe2 into 4.x-dev Nov 23, 2023
22 of 26 checks passed
@sgiehl sgiehl deleted the dev-17439-v4 branch November 23, 2023 11:03
@michalkleiner michalkleiner restored the dev-17439-v4 branch November 27, 2023 19:14
@mneudert mneudert deleted the dev-17439-v4 branch November 28, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@caddoo @sgiehl