Add common download file extensions #21386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asc and sig are commonly used for download signatures. md5 and sha are common download hashes. xz is a common archive type. A combination of these file extensions can be seen on a lot of websites which offer software downloads, with dedicated checksums/hashes and detached signatures to verify integrity and authenticity for the offered downloads. Signed-off-by: MichaIng <[email protected]>
|
This pull request has been mentioned on Matomo forums. There might be relevant details there: https://forum.matomo.org/t/xz-archive-downloads-not-tracked/53528/3 |
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
|
buildjs |
11 tasks
|
Thanks for the pull request @MichaIng, it's much appreciated 😃 Indeed those file extensions are usually downloaded and not shown in the browser so it makes sense to count them as downloads. I've based a new branch and pull request off your fork in order to add the JavaScript minification, but your original commit will still be attributed. I'll close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
asc and sig are commonly used for download signatures. md5 and sha are common download hashes.
xz is a common archive type.
A combination of these file extensions can be seen on a lot of websites which offer software downloads, with dedicated checksums/hashes and detached signatures to verify integrity and authenticity for the offered downloads.
Review