Cast column label to string to stop magic casting issues.

[caddoo]

Description:

Labels can be anything, and PHP likes trying to cast itself. ( see https://3v4l.org/X6v6E#v8.1.24 )

This causes errors, and we can safely assume the key for the array should always be a string.

I didn't modify Row.getColumn's response type or cast within there as there is a lot of code that depends on that and the change would be riskier.

Fixes: #21357

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[michalkleiner]

Looks ok to me on its own, the failing tests seem to be unrelated, so I'd say good to go for 4.x

[sgiehl]

This doesn't look complete to me. You have only changed the place where rowsIndexByLabel is filled, but all places where that array is used to find entries are untouched. This will have the effect, that keys won't be found anymore. Methods like getRowIdFromLabel imho also needs to be adjusted.

additional changes required

[sgiehl]

Looks good now. Before merging this one, we should ensure that there already is a PR for 5.x-dev, so re don't forget to apply the changes there as well.

[caddoo]

Looks good now. Before merging this one, we should ensure that there already is a PR for 5.x-dev, so re don't forget to apply the changes there as well.

Good point, here it is #21393