Fix divide by zero error in cloud visualisation #20386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bx80
added
not-in-changelog
sgiehl
reviewed
Feb 21, 2023
| @@ -194,7 +195,7 @@ private function getPercentage($popularity, $maxValue) | |||
| return 0; | |||
| } | |||
|
|
|||
| $percent = ($popularity / $maxValue) * 100; | |||
| $percent = Piwik::getQuotientSafe($popularity, $maxValue, 4) * 100; | |||
There was a problem hiding this comment.
This actually changes the resulting precision of the number.
Also it actually only covers the real problem why the calculation fails. I'll add a comment to the original issue around that.
There was a problem hiding this comment.
My thinking here is that the percent is being used to decide the size of the words in the cloud visualization, the original unsafe division wasn't applying a precision and four digit precision should be enough accuracy to differentiate between words.
It looks like this is too simplistic an approach and would be better fixed in #19940 - I'll close this PR as it was only intended as a possible quick fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes 20384
Use safe method for division to avoid potential divide by zero error
Review