-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to distinguish between MySQL and MariaDB (also in installation) #18371
Conversation
I'm curios though if there's other functionality that looks for |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
3f35bbe
to
6146b55
Compare
406cd40
to
2ebafe7
Compare
42eb5f1
to
5f0f9f0
Compare
e03225e
to
bd7646d
Compare
plugins/API/tests/System/expected/test_AutoSuggestAPITest__Live.getLastVisitsDetails_range.xml
Show resolved
Hide resolved
Co-authored-by: Marc Neudert <[email protected]>
Description:
This is a small draft how to solve issues that might occur in MariaDb only.
I've only spent a couple of minutes to do the changes, so I'm not even sure if it would even fully work.
I currently don't have time to finish this PR or even test if everything works as expected.
If someone has some time, feel free to pick it up.
When finished this aims to fix #18360
This PR will change some test runs to use MariaDb instead of MySQL. This currently only affects PHP tests (Unit, Integration, System). Due to some fixtures using the same datetime for their visits, the UI tests would currently fail on MariaDb due to different sorting behaviour compared to MySQL.
Requires matomo-org/github-action-tests#16 and matomo-org/plugin-MarketingCampaignsReporting#152
Review