Ensure empty plugin settings are saved correctly #22885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When an array setting was empty, it didn't get sent to the API for processing. We are using a custom empty value to signal that and the API to handle that here.
For Matomo 6 we may consider using json_encoded array instead though that would be a breaking change for now.
You can check that the integration test fails without the JS and PHP changes, and the original issue can also be reproduced by trying to unselect and save all the browsers in the ExampleSettingsPlugin.
Fixes #22877
Ref. DEV-18796
Review