Ensure empty plugin settings are saved correctly #22885
Merged
+56
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
added
c: Usability
|
This should actually target |
michalkleiner
force-pushed
the
dev-18796-plugin-settings-empty-array
branch
from
3d7c0c6 to
6614fd0
Compare
|
I probably confused GH by the force-push and target branch change, so triggered the tests manually here — https://github.com/matomo-org/matomo/actions/runs/12415416589 |
michalkleiner
force-pushed
the
dev-18796-plugin-settings-empty-array
branch
from
6614fd0 to
248b11c
Compare
|
Force-pushed to re-trigger the tests. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When an array setting was empty, it didn't get sent to the API for processing. We are using a custom empty value to signal that and the API to handle that here.
For Matomo 6 we may consider using json_encoded array instead though that would be a breaking change for now.
You can check that the integration test fails without the JS and PHP changes, and the original issue can also be reproduced by trying to unselect and save all the browsers in the ExampleSettingsPlugin.
Fixes #22877
Ref. DEV-18796
Review