Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Ecommece Overview revenue chart broken with change from SEK -> KR #21612

Closed
4 tasks done
9joshua opened this issue Nov 29, 2023 · 2 comments · Fixed by #21614
Closed
4 tasks done

[Bug] Ecommece Overview revenue chart broken with change from SEK -> KR #21612

9joshua opened this issue Nov 29, 2023 · 2 comments · Fixed by #21614
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@9joshua
Copy link
Contributor

9joshua commented Nov 29, 2023

What happened?

It appears that Matomo 5 has changed the currency identifier for the Swedish Krona from SEK to KR
This breaks the Ecommerce -> Overview chart when revenue is shown...
Screenshot from 2023-11-30 12-45-43
This does happen when the currency is change to EUR or USD, etc...
Screenshot from 2023-11-30 12-47-05

It looks like the chart does not scale properly to show KR values.

What should happen?

The chart should be able to scale to the upper limit of KR currency values as it does for other currencies.

How can this be reproduced?

Change the currency for any instance which has tracked ecommerce orders to KR

Matomo major version

Matomo 5

Matomo minor or patch Version

5.0.0-rc8

PHP version

8.2

Server operating system

NA

What browsers are you seeing the problem on?

No response

Computer operating system

NA

Relevant log output

No response

Validations

@9joshua 9joshua added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Nov 29, 2023
@phattrance
Copy link

Please note that this bug happens for Danish (DKK) and Norwegian (NOK) also, and not just Swedish SEK / KR :)

@mneudert mneudert self-assigned this Nov 30, 2023
@mneudert mneudert added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Nov 30, 2023
@mneudert mneudert added this to the 5.0.0 milestone Nov 30, 2023
@mneudert
Copy link
Member

Can confirm it broke for all currencies having two leading characters before the monetary amount, e.g. the already mentioned kr formattings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants