Fix segment SQL fetching for data comparison (#21364)

matomo-org · Oct 4, 2023 · f4209ff · f4209ff
1 parent b9d6dc8
commit f4209ff
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/core/Segment.php b/core/Segment.php
@@ -393,12 +393,17 @@ protected function getCleanedExpression($expression)
         $matchType = $expression[SegmentExpression::INDEX_OPERAND_OPERATOR];
         $value     = $expression[SegmentExpression::INDEX_OPERAND_VALUE];
 
-        $segmentsList = Context::changeIdSite(implode(',', $this->idSites ?: []), function () {
-            return SegmentsList::get();
-        });
-        $segmentObject = $segmentsList->getSegment($name);
-
         $segment = $this->getSegmentByName($name);
+
+        if (empty($this->idSites)) {
+            $segmentsList = SegmentsList::get();
+        } else {
+            $segmentsList = Context::changeIdSite(implode(',', $this->idSites), function () {
+                return SegmentsList::get();
+            });
+        }
+
+        $segmentObject = $segmentsList->getSegment($name);
         $sqlName = $segmentObject->getSqlSegment();
 
         $joinTable = null;