Remove title attribute from user settings (#21631)

matomo-org · Dec 4, 2023 · 9f204bc · 9f204bc
1 parent 7c61ec7
commit 9f204bc
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 22 deletions.
diff --git a/plugins/UsersManager/UsersManager.php b/plugins/UsersManager/UsersManager.php
@@ -352,6 +352,7 @@ public function getClientSideTranslationKeys(&$translationKeys)
         $translationKeys[] = 'UsersManager_PasswordChangeTerminatesOtherSessions';
         $translationKeys[] = 'UsersManager_Pending';
         $translationKeys[] = 'UsersManager_Permissions';
+        $translationKeys[] = 'UsersManager_PersonalSettings';
         $translationKeys[] = 'UsersManager_PleaseStoreToken';
         $translationKeys[] = 'UsersManager_PrivAdmin';
         $translationKeys[] = 'UsersManager_PrivNone';

diff --git a/plugins/UsersManager/templates/userSettings.twig b/plugins/UsersManager/templates/userSettings.twig
@@ -6,7 +6,6 @@
 <div
     vue-entry="UsersManager.UserSettings"
     is-users-admin-enabled="{{ isUsersAdminEnabled|json_encode }}"
-    title="{{ title|json_encode }}"
     user-login="{{ userLogin|json_encode }}"
     user-email="{{ userEmail|json_encode }}"
     current-language-code="{{ currentLanguageCode|json_encode }}"

diff --git a/plugins/UsersManager/vue/dist/UsersManager.umd.js b/plugins/UsersManager/vue/dist/UsersManager.umd.js
diff --git a/plugins/UsersManager/vue/dist/UsersManager.umd.min.js b/plugins/UsersManager/vue/dist/UsersManager.umd.min.js
diff --git a/plugins/UsersManager/vue/src/UserSettings/UserSettings.vue b/plugins/UsersManager/vue/src/UserSettings/UserSettings.vue
@@ -8,7 +8,7 @@
   <div>
     <PersonalSettings
       :is-users-admin-enabled="isUsersAdminEnabled"
-      :title="title"
+      :title="translate('UsersManager_PersonalSettings')"
       :user-login="userLogin"
       :user-email="userEmail"
       :current-language-code="currentLanguageCode"
@@ -56,10 +56,6 @@ export default defineComponent({
       type: Boolean,
       required: true,
     },
-    title: {
-      type: String,
-      required: true,
-    },
     userLogin: {
       type: String,
       required: true,