avoid unnecessary screenshots in updater tests

matomo-org · Sep 19, 2023 · 730308e · 730308e
1 parent 0fd1e0f
commit 730308e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 14 deletions.
diff --git a/plugins/Login/tests/UI/Invite_spec.js b/plugins/Login/tests/UI/Invite_spec.js
@@ -45,7 +45,7 @@ describe('Invite', function () {
       $('#login_form_submit').click();
     });
     // should show site without data page
-    await page.waitForNetworkIdle();
-    await page.waitForSelector('#site-without-data');
+    await page.waitForSelector('#site-without-data', {visible: true});
+    await page.evaluate(() => window.stop()); // stop ongoing requests
   });
 });
diff --git a/tests/UI/expected-screenshots/OneClickLastForcedUpdate_login.png b/tests/UI/expected-screenshots/OneClickLastForcedUpdate_login.png
diff --git a/tests/UI/expected-screenshots/OneClickUpdate_login.png b/tests/UI/expected-screenshots/OneClickUpdate_login.png
diff --git a/tests/UI/specs/OneClickLastForcedUpdate_spec.js b/tests/UI/specs/OneClickLastForcedUpdate_spec.js
@@ -90,9 +90,9 @@ describe("OneClickLastForcedUpdate", function () {
             }
         }
 
-        await page.waitForSelector('#start-tracking-method-list', { visible: true });
-        await page.waitForNetworkIdle();
-        expect(await element.screenshot()).to.matchImage('login');
+        // avoid taking an unnecessary screenshot, as knowing we land on #site-without-data is enough
+        await page.waitForSelector('#site-without-data', { visible: true });
+        await page.evaluate(() => window.stop()); // stop ongoing requests
     });
 
     it('should have a working cron archiving process', async function () {

diff --git a/tests/UI/specs/OneClickUpdate_spec.js b/tests/UI/specs/OneClickUpdate_spec.js
@@ -96,9 +96,9 @@ describe("OneClickUpdate", function () {
             }
         }
 
-        await page.waitForSelector('#start-tracking-method-list', { visible: true });
-        await page.waitForNetworkIdle();
-        expect(await element.screenshot()).to.matchImage('login');
+        // avoid taking an unnecessary screenshot, as knowing we land on #site-without-data is enough
+        await page.waitForSelector('#site-without-data', { visible: true });
+        await page.evaluate(() => window.stop()); // stop ongoing requests
     });
 
     it('should have a working cron archiving process', async function () {