fix new checks for GA

matomo-org · Sep 1, 2023 · 0fd36cd · 0fd36cd
1 parent eda3142
commit 0fd36cd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/plugins/SitesManager/Controller.php b/plugins/SitesManager/Controller.php
@@ -24,7 +24,6 @@
 use Piwik\Plugins\SitesManager\SiteContentDetection\GoogleAnalytics4;
 use Piwik\Plugins\SitesManager\SiteContentDetection\SiteContentDetectionAbstract;
 use Piwik\Plugins\SitesManager\SiteContentDetection\WordPress;
-use Piwik\Site;
 use Piwik\SiteContentDetector;
 use Piwik\Session;
 use Piwik\SettingsPiwik;
@@ -236,7 +235,7 @@ public function siteWithoutDataTabs()
             'consentManagerName' => false,
             'defaultSiteDecoded' => [
                 'id' => $this->idSite,
-                'name' => Common::unsanitizeInputValue(Site::getNameFor($this->idSite)),
+                'name' => Common::unsanitizeInputValue($this->site->getName()),
             ],
             'maxCustomVariables' => $maxCustomVariables,
             'serverSideDoNotTrackEnabled' => $dntChecker->isActive()

diff --git a/plugins/SitesManager/templates/_siteWithoutDataTabs.twig b/plugins/SitesManager/templates/_siteWithoutDataTabs.twig
@@ -108,7 +108,7 @@
 
         {% if googleAnalyticsImporterMessage is defined and googleAnalyticsImporterMessage is not empty  %}
             {{ googleAnalyticsImporterMessage|raw }}
-        {% elseif not ga3Used and not ga4Used %}
+        {% elseif not 'GoogleAnalytics3' in jsFrameworks and not 'GoogleAnalytics4' in jsFrameworks %}
             <h3>{{ 'SitesManager_ImportDataFromGoogleAnalytics'|translate }}</h3>
             <p>{{ 'SitesManager_ImportDataFromGoogleAnalyticsDescription'|translate('<a target="_blank" rel="noreferrer noopener" href="https://matomo.org/guide/installation-maintenance/import-google-analytics/">', '</a>')|raw }}</p>
         {% endif %}