allow disabling async archiving via advanced setting #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Oct 8, 2023
tsteur
approved these changes
Oct 13, 2023
diosmosis
force-pushed
the
844-matomo-const-in-ui
branch
from
91db767 to
6d5f09c
Compare
tsteur
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #844
I've noticed users can have trouble with manually editing wp-config.php, and hosting providers can cater to people who do not have the skills to do or want to do that kind of maintenance. It would be a lot simpler for a user to simply uncheck a setting than edit a file on their server.
Since the main setting that users may have to interact with is
MATOMO_SUPPORT_ASYNC_ARCHIVING, adding a setting for this seems like a good idea and a quick win.FAQs may need to be updated after this is released.
Review