Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to show notifications for new features in matomo for wordpress #1226

Merged
merged 27 commits into from
Dec 19, 2024
Merged

add ability to show notifications for new features in matomo for wordpress #1226

merged 27 commits into from
Dec 19, 2024

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Dec 4, 2024 •
edited
Loading

Description:

Changes:

  • Add new feature class for showing notices to the user for content we want them to see at least once. These notifications show a red dot on the WordPress menu when they haven't been seen.
  • Add notice that promotes CrashAnalytics.
  • Do not log errors when scheduling a cron event results in "could_not_set" error, as this can be due to there being an event already scheduled.

Review

@diosmosis diosmosis marked this pull request as draft December 4, 2024 14:22
@diosmosis
add JS to dismiss whats new notification + start on notification dot css
3545fc9
@diosmosis
add filter to allow other parts of MWP to edit matomo submenu informa…
1f0280b 
…tion
@diosmosis
revert menu changes and go to javascript approach so pages added outs…
0c2241b 
…ide of the MWP plugin can have notification dots as well
@diosmosis
in wordpress:download-test-screenshots use curl CLI command instead o…
c152857 
…f PHP curl due to issue in github API
@diosmosis
try to fix e2e test failure
bf502ef
@diosmosis
Merge branch 'develop' into crashanalytics-new
cce78b7
@diosmosis
finalize look of promo and marketplace changes
f193c51
@diosmosis
allow whats new notifications to determine exactly when they should s…
407fccc 
…how rather than hardcoding is_super_admin()
@diosmosis
translate crash analytics promo text
627b610
@diosmosis
stub unit tests for new WhatsNewNotifications feature
c181700
@diosmosis
add first unit test for WhatsNewNotifications
4da419a
@diosmosis
add tests for WhatsNewNotification::is_active
ffd3434
@diosmosis
add tests for register_hooks
91809cf
@diosmosis
add tests for on_admin_notices hook
85a82f1
@diosmosis
finish unit tests for WhatsNewNotifications feature and get to pass
c09c05d
@diosmosis
add e2e test for notifications
704dde1
@diosmosis
fix import
a20fb5f
@diosmosis
debug failing test
e00f799
@diosmosis
fix random new url path issue in test
c0bc5f4
@diosmosis
update existing screenshots and add pause
1a1c75e
@diosmosis
Merge branch 'develop' into crashanalytics-new
3dd391a
@diosmosis
update expected screenshot
13b2645
@diosmosis
fill out PR TODO
b2de1d9
@diosmosis diosmosis marked this pull request as ready for review December 19, 2024 07:54
@diosmosis diosmosis merged commit f7eacdb into develop Dec 19, 2024
11 checks passed
@diosmosis diosmosis deleted the crashanalytics-new branch December 19, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@diosmosis