-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update live for upcoming 5.1.3 release #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove about section from get started, rename About page to Help and reorganize the contents of said page to de-emphasize the about section * re-order steps in Get Started page and add some line breaks for clarity * redirect to get started on plugin activation * show all tracking settings by default * break up extremely long function calls into multiple lines * try to fix tests * fix random failure * add more text to the get started page * translate the added text * inaccuracy in changelog * add convenience script to connect to the mariadb database * update expected screenshots * translate text
* bump minimum tested versions * update screenshots
* regroup tracking settings under more specific categories * change track mode setting to be a set of radio buttons instead of select * tweaks to tracking form table styles * always show tagmanager tracking mode, but disabled when there are no containers. also set attribute on form element when track mode changes. * remove inaccurate todo * add intro text for each tracking settings section * in auto tracking settings section, add place to display generated tracking code (generation ajax method defined but not filled out) * implement preview of tracking code for auto tracking settings * getting new generated tracking code display to work properly in tracking settings page * prompt user when there are unsaved changes (added since tracker settings form is large) * tweaks to tracking settings styles, docs and behavior * make tracking settings sections collapsible * more grouping of tracking settings * always display inline documentation + a couple other bits of tidying up * more tracking settings tweaks * auto-expand tracking setting section if hash points to a collapsible section * remove hash on saving tracking settings * add note to help for tracker debug on demand setting * remove unclear comment * refactor GeneratorOptions to immediately reflect changes to settings + add unit tests for generatoroptions * add unit test for tracking code generation based on request * add missing setting and mention when a setting only applies to two tracking modes rather than all three * redesign tagmanager container select in tracking settings * remove backoffice tracking sub-category since userid tracking does not fit into it * tweak label * use slider instead of checkbox for boolean tracker settings * grey out section header for tracking settings that apply to a specific tracking mode, when the tracking mode is not selected * link to faq in tag manager tracking mode notice * add another submit button after tracking mode settings * for auto and manual tracking mode, auto-expand/collapse settings section when aforementioned modes are selected * move tagmanager container select to under tagmanager radio button * clearer description for tag manager tracking mode * tweak section titles * fix incorrect nonce implementation * code review * move environment setup for wordpress and matomo in unit tests to new fixture classes * start adding tests for ajax methods * fill out tests for is_marketplace_active ajax method * use correct instance when handling @provideContainerConfig * use reset_roles() method in fixture as it was moved there * get is_marketplace_active ajax tests to pass * add tests for the activate plugin marketplace ajax method * add unit test for tracking code generation ajax method * fix site id in test * add new e2e tests for tracking settings page changes * fix tagmanager track mode selection in e2e tests * correct webdriverio methods * update wpstat import test for new wpstatistics version * fix test selector * fix another selector * fix unit test failure in multisite environment * try downloading geolitecity database for wpstatistics since the download from within the plugin fails during tests * fix geoip db download in test-import * try to fix the import test * correct waitUntil usage * attempting more test fixes * more attempts to fix tests * more attempts to fix tests * remove container ids before screenshot * fix incorrect post parameter queries * add a debounce to tracking code generation * more screenshot normalization * update expected screenshots * show description of add matomo campaign params to rss feed links setting * show description of another tracking setting * update expected test files
* add test to make sure bundled core is the latest matomo version * move matomo_scoper_path check to top of update-core.sh * add check for running local environment * run generate-core-assets in update-core.sh * update core to 5.1.1 * run tests once a week automatically * allow tests to be triggered manually
…1190) * add tests to check that tested up to versions are always up to date * read from response body correctly
* version 5.1.3 tweaks (typo and escaping an id) * update expected screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As title.
Review