Skip to content

Commit

Permalink
version 5.1.3 tweaks (typo and escaping an id) (#1193)
Browse files Browse the repository at this point in the history
* version 5.1.3 tweaks (typo and escaping an id)

* update expected screenshots
  • Loading branch information
diosmosis authored Sep 8, 2024
1 parent ea758de commit 1978404
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions classes/WpMatomo/Admin/TrackingSettings/Forms.php
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public function show_radio( $id, $name, $options = [], $description = '', $on_ch
. $desc,
( $tooltip ? ' title="' . esc_attr( $tooltip ) . '"' : '' ),
$radio_id,
esc_attr( TrackingSettings::FORM_NAME ) . '[' . $id . ']',
esc_attr( TrackingSettings::FORM_NAME ) . '[' . esc_attr( $id ) . ']',
esc_attr( $key ),
// phpcs:ignore WordPress.PHP.StrictComparisons.LooseComparison
( $key == $default ? 'checked="checked"' : '' ),
Expand All @@ -246,7 +246,7 @@ public function show_radio( $id, $name, $options = [], $description = '', $on_ch
. '</tr>',
esc_html( $name ),
$script_change,
$id,
esc_attr( $id ),
implode( is_array( $description ) ? '' : '<br/>', $button_list ),
is_array( $description ) ? '' : $this->get_description( $id, $description, $hide_description )
);
Expand Down
2 changes: 1 addition & 1 deletion classes/WpMatomo/Admin/views/info.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<br/><br/>
<?php
echo sprintf(
esc_html__( 'Matomo will always cost you nothing to use, but that if you\'d like to support Matomo in a more meaningful way, take a look at our %1$spremium plugins%2$s.', 'matomo' ),
esc_html__( 'Matomo will always cost you nothing to use, but if you\'d like to support Matomo in a more meaningful way, take a look at our %1$spremium plugins%2$s.', 'matomo' ),
'<a href="https://plugins.matomo.org/premium" target="_blank" rel="noreferrer noopener">',
'</a>'
);
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/baseline/desktop_firefox/mwp-admin.about.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/e2e/baseline/desktop_firefox/mwp-admin.about.trunk.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 1978404

Please sign in to comment.