1. Set access for Filename property of TableWriter.

2. Add more error tests. Co-authored-by: Sarah Gilmore <[email protected]>
mathworks · Sep 18, 2023 · bedaf98 · bedaf98
1 parent 66744a2
commit bedaf98
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/matlab/src/matlab/+arrow/+io/+csv/TableWriter.m b/matlab/src/matlab/+arrow/+io/+csv/TableWriter.m
@@ -20,7 +20,7 @@
         Proxy
     end
 
-    properties(Dependent)
+    properties(Dependent, SetAccess=private, GetAccess=public)
         Filename
     end
 
@@ -36,6 +36,10 @@
         end
 
         function write(obj, table)
+            arguments
+                obj (1, 1) arrow.io.csv.TableWriter
+                table (1, 1) arrow.tabular.Table
+            end
             args = struct(TableProxyID=table.Proxy.ID);
             obj.Proxy.write(args);
         end

diff --git a/matlab/test/arrow/io/csv/tError.m b/matlab/test/arrow/io/csv/tError.m
@@ -47,6 +47,27 @@ function InvalidReaderFilenameType(testCase)
             testCase.verifyError(fcn, "MATLAB:validation:IncompatibleSize");
         end
 
+        function InvalidWriterWriteType(testCase)
+            import arrow.io.csv.*
+            writer = TableWriter(testCase.Filename);
+            fcn = @() writer.write("text");
+            testCase.verifyError(fcn, "MATLAB:validation:UnableToConvert");
+        end
+
+        function WriterFilenameNoSetter(testCase)
+            import arrow.io.csv.*
+            writer = TableWriter(testCase.Filename);
+            fcn = @() setfield(writer, "Filename", "filename.csv");
+            testCase.verifyError(fcn, "MATLAB:class:SetProhibited");
+        end
+
+        function ReaderFilenameNoSetter(testCase)
+            import arrow.io.csv.*
+            reader = TableReader(testCase.Filename);
+            fcn = @() setfield(reader, "Filename", "filename.csv");
+            testCase.verifyError(fcn, "MATLAB:class:SetProhibited");
+        end
+
     end
 
 end