Fix search terms for " and "" (mozilla#3017)

mathjazz · Nov 10, 2023 · 20de532 · 20de532
1 parent b2d4cbc
commit 20de532
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/translate/src/modules/placeable/components/Highlight.test.js b/translate/src/modules/placeable/components/Highlight.test.js
@@ -121,6 +121,20 @@ describe('<Highlight search>', () => {
     expect(marks.at(0).hasClass('search'));
     expect(marks.at(0).text()).toEqual('456');
   });
+
+  it('does not break for lone " quotes', () => {
+    const wrapper = mountMarker('123456"', [], '"');
+    const marks = wrapper.find('mark');
+    expect(marks).toHaveLength(2);
+    expect(marks.at(1).text()).toEqual('"');
+  });
+
+  it('does not break for doubled "" quotes', () => {
+    const wrapper = mountMarker('123456""', [], '""');
+    const marks = wrapper.find('mark');
+    expect(marks).toHaveLength(2);
+    expect(marks.at(1).text()).toEqual('""');
+  });
 });
 
 describe('specific marker', () => {

diff --git a/translate/src/modules/placeable/components/Highlight.tsx b/translate/src/modules/placeable/components/Highlight.tsx
@@ -168,14 +168,14 @@ export function Highlight({
   if (search) {
     const searchTerms = search.match(/(?<!\\)"(?:\\"|[^"])+(?<!\\)"|\S+/g);
     for (let term of searchTerms ?? []) {
-      if (term.startsWith('"') && term.endsWith('"')) {
+      if (term.startsWith('"') && term.length >= 3 && term.endsWith('"')) {
         term = term.slice(1, -1);
       }
       let lcTerm = term.toLowerCase();
       let pos = 0;
       let next: number;
       while ((next = lcSource.indexOf(lcTerm, pos)) !== -1) {
-        let i = marks.findIndex((m) => m.index + m.length >= next);
+        let i = marks.findIndex((m) => m.index + m.length > next);
         if (i === -1) {
           i = marks.length;
         }