Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

[WIP] Adding Carthage support #126

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[WIP] Adding Carthage support #126

wants to merge 1 commit into from

Conversation

rynecheow
Copy link

@rynecheow rynecheow commented Mar 13, 2019

Adding Carthage support by creating MotionAnimator.framework target with it's scheme shared so that Carthage is able to find and build the shared scheme according to what is defined in the scheme.

By correctly exposing the public headers and hiding the private headers, this will also tell Xcode to build and include the correct headers available to library consumers.

Pre-requisite:

  1. Adding Carthage support motion-interchange-objc#45 is merged
  2. New tagged version is released on https://github.com/material-motion/motion-interchange-objc

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #126 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #126   +/-   ##
========================================
  Coverage    87.92%   87.92%           
========================================
  Files            9        9           
  Lines          613      613           
========================================
  Hits           539      539           
  Misses          74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cafc9e...18c07b9. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant