Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show icons in releases page. #98

Merged

Conversation

mikeydevelops
Copy link
Contributor

@mikeydevelops mikeydevelops commented Jul 5, 2024

This closes #81, as the pull brings support for displaying icons in releases page.

Provider support:

  • GitHub
  • GitLab
  • Gitea
  • Gitee
  • Azure - releases feature different from github.
  • BitBucket - releases feature not supported
  • SourceForge - releases feature not supported

@PKief
Copy link
Member

PKief commented Jul 6, 2024

@material-extensions/material-icons-browser-extension Is there anyone from our maintainer team who has access to an Azure repository and its releases page and can support us here? It would already help to get to know the HTML structure of that page.

src/lib/replace-icon.ts Outdated Show resolved Hide resolved
@mikeydevelops mikeydevelops force-pushed the feature/icons-in-releases branch from 3899d19 to af11bc3 Compare July 6, 2024 15:02
@mikeydevelops
Copy link
Contributor Author

So Azure Repos is free, and I was able to mirror the repository on there and make an automated build, but the releases function is different than github, gitlab, gitea or gitee. There is no file list to download the build from. So this is pretty much done.

@PKief
Copy link
Member

PKief commented Jul 8, 2024

So Azure Repos is free, and I was able to mirror the repository on there and make an automated build, but the releases function is different than github, gitlab, gitea or gitee. There is no file list to download the build from. So this is pretty much done.

Nice, then we can merge this for now. I was only able to test it on GitHub, but there it worked very well 👍

@PKief PKief merged commit 12ce1eb into material-extensions:main Jul 9, 2024
1 check passed
@mikeydevelops mikeydevelops deleted the feature/icons-in-releases branch July 9, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Icon in Release
2 participants