{clang-format} Format the components. #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #6027
|
This PR affects multiple components. |
romoore
requested review from
ianegordon,
randallli and
fluxminds
as code owners
material-automation
bot
added
[ActionSheet]
[ActivityIndicator]
[AnimationTiming]
[AppBar]
[BottomAppBar]
[BottomNavigation]
[BottomSheet]
[ButtonBar]
[Buttons]
[Cards]
[Chips]
[CollectionCells]
[Collections]
[Dialogs]
[FeatureHighlight]
[FlexibleHeader]
[Ink]
[List]
[MaskedTransition]
labels
romoore
removed request for
a team,
ianegordon,
galiak11,
yarneo,
codeman7,
andrewoverton and
fluxminds
yarneo
reviewed
Jan 16, 2019
| @"Irony", | ||
| @"Gastropub", | ||
| @"Truffaut" | ||
| @"Truffaut", @"Farm-to-table", @"XOXO", @"Chillwave", @"Fanny", @"Pack", |
| @@ -124,7 +112,7 @@ + (void)applySemanticColorScheme:(nonnull id<MDCColorScheming>)colorScheme | |||
|
|
|||
| + (void)resetUIControlStatesForChipTheming:(nonnull MDCChipView *)chipView { | |||
| NSUInteger maximumStateValue = UIControlStateNormal | UIControlStateSelected | | |||
| UIControlStateHighlighted | UIControlStateDisabled; | |||
| UIControlStateHighlighted | UIControlStateDisabled; | |||
There was a problem hiding this comment.
Looks like it matches how we've done logical/arithmetic operators across multiple lines in other places.
| UIColor *customBackgroundColor = | ||
| [_delegate collectionView:_collectionView cellBackgroundColorAtIndexPath:attr.indexPath]; | ||
| UIColor *customBackgroundColor = [_delegate collectionView:_collectionView | ||
| cellBackgroundColorAtIndexPath:attr.indexPath]; |
There was a problem hiding this comment.
This is aligning the colons, so it makes sense if the method invocation starts on the preceding line.
romoore
commented
Jan 17, 2019
romoore
commented
Jan 17, 2019
components/AnimationTiming/src/CAMediaTimingFunction+MDCAnimationTiming.m
Outdated
Show resolved
Hide resolved
|
This PR affects multiple components. |
|
This PR affects multiple components. |
|
Ready for re-review |
yarneo
approved these changes
Jan 23, 2019
romoore
pushed a commit
that referenced
this pull request
Jan 23, 2019
This is a follow-up to #6027 ``` find components \( -name "*.h" -or -name "*.m" \) | xargs clang-format -i ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6027