Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #267.
I didn't check vector-matrix multiplication. Just submitting this PR for discussion.
I don't like this because it feels very hardcoded. Ideally, multiply should check dimensions and handle 1×1, 1×2, 2×1 & 2×2.
Ideally, matrix multiplication should work for matrices of arbitrary dimensions and is quite straightforward to implement - and use blas only for 2×2.