-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone catalog #565
base: master
Are you sure you want to change the base?
Phone catalog #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, but don't forget to provide the demo link
Yeah, sure: https://olshum8.github.io/react_phone-catalog/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
Pay attention on such moments.
- somethin went wrong with favorite icons
- add cursor pointer and hover effect for all interactive elements (links, buttons...). For example navigation buttons for main slider.
- somethin went wrong with product details page
- not visible border right in last visible slide
- check path to category images and logo in footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
To improve:
- Add the topical title and favicon on the page
- When we change the number of products in the cart, the number needs to be updated in the upper right corner next to the icon.
- Add the your github profile for all these links and open them in the new tab
- When we go to the product page, the page should automatically scroll up.
- Also, check the font family as on the design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I fixed the fonts, but now it looks a little terrible, but the specs are the same as on the figma design. Other points looks better now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
I've been working on this site for a long time, and I'd really appreciate your feedback, suggestions, or comments. I'm currently in the process of redesigning components because I've found better ways of doing things. I'm not quite sure what the final result should look like, though. Thanks in advance :)