Implemented method getSalaryInfo #1387
Conversation
There was a problem hiding this comment.
Great job on implementing the SalaryInfo class! 🎉 Your solution meets the task requirements effectively, and you've used best practices like StringBuilder and LocalDate. While there's a minor formatting issue with the initial line separator in the report, it doesn't impact the core functionality. Keep up the good work, and consider refining the string formatting for even cleaner output in the future. Well done! 👏
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| } | ||
| builder.append(System.lineSeparator()).append(name).append(" - ").append(salary); | ||
| } | ||
| return "Report for period " + dateFrom + " - " + dateTo + builder; |
There was a problem hiding this comment.
The return statement concatenates the report header with the salary information using the StringBuilder. However, the builder starts with a line separator, which might lead to an unexpected format in the report. Consider adjusting the StringBuilder initialization or appending logic to ensure the format matches the expected output.
| return null; | ||
| LocalDate dateFromFormed = LocalDate.parse(dateFrom, FORMATTER); | ||
| LocalDate dateToFormed = LocalDate.parse(dateTo, FORMATTER); | ||
| StringBuilder builder = new StringBuilder(); |
There was a problem hiding this comment.
uninformative naming, avoid naming String string, StringBuilder builder etc - name container types after what they store
| int salary = 0; | ||
| for (String info: data) { | ||
| String[] information = info.split(" "); | ||
| LocalDate dateFormed = LocalDate.parse(information[0], FORMATTER); |
There was a problem hiding this comment.
let's create constants for those indexes
| } | ||
| salaryAmount.append(System.lineSeparator()).append(name).append(" - ").append(salary); | ||
| } | ||
| return "Report for period " + dateFrom + " - " + dateTo + salaryAmount; |
There was a problem hiding this comment.
separator also should be a constant field
No description provided.