v1 #1385
v1 #1385
Conversation
There was a problem hiding this comment.
Thank you for your efforts on this task! 😊 However, there are a few critical issues that need to be addressed before we can approve your Pull Request. The getSalaryInfo method currently does not meet the core requirements of the task. Specifically, it fails to calculate salaries correctly, handle date filtering, and iterate over the data properly. Please revise your implementation to ensure it calculates the total salary for each employee within the specified date range and formats the output as required. Keep up the hard work, and don't hesitate to reach out if you need further guidance!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| for (int i = 0; i < names.length; i++) { | ||
| stringBuilder.append(names[0]).append(" - ").append(data[0]).append("\n"); |
There was a problem hiding this comment.
The loop is intended to iterate over each name in the names array, but it incorrectly uses names[0] and data[0] in the append method. This results in the same name and data being appended repeatedly. You should use names[i] and the corresponding data for each name to ensure the correct information is appended for each person.
No description provided.