Solution #1374
Open
Solution #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliia-ponomarenko
suggested changes
Nov 28, 2024
Comment on lines
7
to
9
| private static final DateTimeFormatter DATE_FORMATTER = ( | ||
| DateTimeFormatter.ofPattern("dd.MM.yyyy") | ||
| ); |
There was a problem hiding this comment.
Suggested change
| private static final DateTimeFormatter DATE_FORMATTER = ( | |
| DateTimeFormatter.ofPattern("dd.MM.yyyy") | |
| ); | |
| private static final DateTimeFormatter DATE_FORMATTER = | |
| DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
redundant brackets
There was a problem hiding this comment.
Is this a best practice in Java?
There was a problem hiding this comment.
yes, don't complicate the code unnecessarily
| return null; | ||
| StringBuilder result = new StringBuilder( | ||
| "Report for period " | ||
| ).append(dateFrom).append(" - ").append(dateTo).append("\n"); |
There was a problem hiding this comment.
Create constant variables for all literals like HEADER, SEPARATOR, etc.
Use System.lineseparator instead of "\n"
Comment on lines
28
to
31
| if ( | ||
| workerName.equals(name) && (date.isEqual(fromDate) | ||
| || date.isEqual(toDate) | ||
| || (date.isAfter(fromDate) && date.isBefore(toDate))) |
There was a problem hiding this comment.
better move this conditional to the private method
| result.append(name).append(" - ").append(salary).append("\n"); | ||
| } | ||
|
|
||
| return result.deleteCharAt(result.length() - 1).toString(); |
There was a problem hiding this comment.
think how you can avoid .deleteCharAt
liliia-ponomarenko
approved these changes
Nov 29, 2024
| } | ||
| result[i + 1] = name + SEPARATOR + salary; | ||
| } | ||
| return String.join("\n", result); |
There was a problem hiding this comment.
Suggested change
| return String.join("\n", result); | |
| return String.join(System.lineseparator(), result); |
Comment on lines
+7
to
+8
| private static String HEADER = "Report for period "; | ||
| private static String SEPARATOR = " - "; |
There was a problem hiding this comment.
Suggested change
| private static String HEADER = "Report for period "; | |
| private static String SEPARATOR = " - "; | |
| private static final String HEADER = "Report for period "; | |
| private static final String SEPARATOR = " - "; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.