Implement method getSalaryInfo #1373
Conversation
There was a problem hiding this comment.
Great job on implementing the SalaryInfo class! 🎉 The code meets the task requirements and constraints effectively. While there are some potential issues with date parsing and comparison, these are minor and can be addressed in future improvements. Keep up the good work and consider adding validation or exception handling for date formats to make your code even more robust. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| LocalDate startDate = LocalDate.parse(dateFrom, DATE_FORMATTER); | ||
| LocalDate endDate = LocalDate.parse(dateTo, DATE_FORMATTER); |
There was a problem hiding this comment.
Ensure that the dateFrom and dateTo parameters are correctly formatted as 'dd.MM.yyyy'. If they are not, LocalDate.parse will throw a DateTimeParseException. Consider adding validation or exception handling to manage incorrect date formats.
| int totalSalary = 0; | ||
| for (String record : data) { | ||
| String[] recordParts = record.split(" "); | ||
| LocalDate workDate = LocalDate.parse(recordParts[0], DATE_FORMATTER); |
There was a problem hiding this comment.
Similar to the previous comment, ensure that the date in recordParts[0] is correctly formatted as 'dd.MM.yyyy'. If not, this will also throw a DateTimeParseException. Consider adding validation or exception handling here as well.
No description provided.