first commit #1358
first commit #1358
Conversation
There was a problem hiding this comment.
Great job on implementing the core functionality! 🎉 While there are a few minor improvements suggested, such as correcting the variable name from raport to report and ensuring the date range logic is inclusive, these do not critically impact the functionality. Keep up the good work, and consider the feedback for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| String dateFrom = "15.04.2019"; | ||
| String dateTo = "31.04.2019"; | ||
|
|
||
| String raport = SalaryInfo.getSalaryInfo(names, data, dateFrom, dateTo); |
There was a problem hiding this comment.
The variable name raport seems to be a typo. It should be report to match the standard English spelling and improve code readability.
|
|
||
| String raport = SalaryInfo.getSalaryInfo(names, data, dateFrom, dateTo); | ||
|
|
||
| System.out.println(raport); |
There was a problem hiding this comment.
Ensure that the variable name raport is corrected to report here as well, to maintain consistency after the change.
| if (workDate.isAfter(from) && workDate.isBefore(to) | ||
| || workDate.isEqual(from) || workDate.isEqual(to)) { |
There was a problem hiding this comment.
The condition for checking if workDate is within the range might be misleading. Ensure that the logic correctly includes both from and to dates as intended. The current condition workDate.isAfter(from) && workDate.isBefore(to) || workDate.isEqual(from) || workDate.isEqual(to) should work, but double-check if it aligns with the task requirements for inclusivity.
No description provided.