Added logic to 'getSalaryInfo' method #1077
Conversation
| .append(dateFrom).append(" - ") | ||
| .append(dateTo); | ||
|
|
||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("d.MM.yyyy"); |
There was a problem hiding this comment.
It is recommended to make your formatter a constant field
| && workDay.isAfter(startDate) | ||
| && (workDay.isEqual(endDate) | ||
| || workDay.isBefore(endDate))) { |
There was a problem hiding this comment.
I believe we can simplify this if statement by only checking on !isBefore and !isAfter, what do you think?
| .append(dateFrom).append(" - ") | ||
| .append(dateTo); | ||
|
|
||
| final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("d.MM.yyyy"); |
There was a problem hiding this comment.
Please, make your formatter a constant (private static final and class level)
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| String paragraph = System.lineSeparator(); | ||
| StringBuilder builder = new StringBuilder("Report for period ") |
There was a problem hiding this comment.
I recommend you be more specific in this case because the builder name is too generic
| if (name.equals(employeeInfo[1]) | ||
| && !workDay.isAfter(endDate) | ||
| && !workDay.isBefore(startDate)) { | ||
| totalSalary += Integer.parseInt(employeeInfo[2]) | ||
| * Integer.parseInt(employeeInfo[3]); | ||
| } | ||
| } |
There was a problem hiding this comment.
It's hard to understand what is stored under arrayName[someIndex] without knowing the input format, it's always better to extract such expressions in separate variables with proper names to give some context on what is actually going on
No description provided.