all tasks are solved #1163
Open
all tasks are solved #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliia-ponomarenko
suggested changes
Jan 7, 2025
Comment on lines
18
to
21
| for (User element: users) { | ||
| if (email.equals(element.getEmail())) { | ||
| return element; | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (User element: users) { | |
| if (email.equals(element.getEmail())) { | |
| return element; | |
| } | |
| for (User user: users) { | |
| if (email.equals(user.getEmail())) { | |
| return user; | |
| } |
| @@ -11,6 +13,17 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| UserService newUserSerice = new UserService(); | |||
There was a problem hiding this comment.
better make it class level variable
Comment on lines
17
to
26
| User user1 = newUserSerice.findByEmail(email); | ||
| if (user1 == null) { | ||
| return false; | ||
| } else { | ||
| String correctPassword = user1.getPassword(); | ||
| if (password.equals(correctPassword)) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Avoid nesting conditional operators. One if block is enough, think about how to combine conditions and simplify your solution.
sarakhmen
approved these changes
Jan 7, 2025
Comment on lines
+18
to
+19
| User user1 = newUserSerice.findByEmail(email); | ||
| return user1 != null && password.equals(user1.getPassword()); |
There was a problem hiding this comment.
Suggested change
| User user1 = newUserSerice.findByEmail(email); | |
| return user1 != null && password.equals(user1.getPassword()); | |
| User user = newUserSerice.findByEmail(email); | |
| return user != null && password.equals(user.getPassword()); |
actually it's a bad practice to add such suffixes to the var names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a login method in AuthenticationService and findByEmail method in UserService