Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #1151

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

update #1151

Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,18 @@ public class AuthenticationService {
* Imagine that some user wants to login to your site.
* You should check if user credentials (login and password) are valid or not.
* All users are stored in <code>UserService</code> class.
* @param email - user's email
*
* @param email - user's email
* @param password - user's password
* @return true if user by email exists and passed password is equal to user's password.
* Return false in any other cases.
*/
private final UserService service = new UserService();

public boolean login(String email, String password) {
if (service.findByEmail(email) != null) {
return service.findByEmail(email).getPassword().equals(password);
}
return false;
Copy link

@okuzan okuzan Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you call findByEmal twice. save the result of the single call to a local variable, and reuse it. Try to use only one return in this method (combine conditions with &&)

}
}
5 changes: 5 additions & 0 deletions src/main/java/mate/academy/service/UserService.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ public class UserService {
* Return <code>null</code> if there is no suitable user
*/
public User findByEmail(String email) {
for (User tempUser : users) {
if (tempUser.getEmail().equals(email)) {
return tempUser;
}
}
return null;
}
}
Loading