Test improvements

matchory · Feb 11, 2021 · e0a0351 · e0a0351
1 parent 073a528
commit e0a0351
Show file tree

Hide file tree

Showing 2 changed files with 74 additions and 10 deletions.
diff --git a/tests/BodyTest.php b/tests/BodyTest.php
@@ -47,12 +47,6 @@ protected function getExpected(array $body = []): array
     {
         $query = $this->getQueryArray();
 
-        if ( ! isset($body['_source'])) {
-            $body['_source'] = [
-                'include' => [],
-                'exclude' => [],
-            ];
-        }
 
         $query['body'] = $body;
 

diff --git a/tests/ModelTest.php b/tests/ModelTest.php
@@ -27,20 +27,90 @@ class ModelTest extends TestCase
 {
     public function testResolveRouteBinding(): void
     {
-        // TODO: Create mock connection
+        /** @var MockObject<Connection> $connection */
+        $connection = $this->app
+            ->get(ConnectionResolverInterface::class)
+            ->connection();
+
+        $connection
+            ->expects(self::any())
+            ->method('__call')
+            ->with('search', [
+                [
+                    'body' => [
+                        'query' => [
+                            'bool' => [
+                                'filter' => [
+                                    [
+                                        'term' => [
+                                            '_id' => 42,
+                                        ],
+                                    ],
+                                ],
+                            ],
+                        ],
+                    ],
+                    'from' => 0,
+                    'size' => 1,
+                ],
+            ])
+            ->willReturn([
+                'hits' => [
+                    'hits' => [
+                        [
+                            '_id' => '42',
+                        ],
+                    ],
+                ],
+            ]);
 
         $model = (new Model())->resolveRouteBinding(42);
 
-        self::assertSame($model->_id, 42);
+        self::assertSame($model->_id, '42');
     }
 
     public function testResolveRouteBindingFromField(): void
     {
-        // TODO: Create mock connection
+        /** @var MockObject<Connection> $connection */
+        $connection = $this->app
+            ->get(ConnectionResolverInterface::class)
+            ->connection();
+
+        $connection
+            ->expects(self::any())
+            ->method('__call')
+            ->with('search', [
+                [
+                    'body' => [
+                        'query' => [
+                            'bool' => [
+                                'filter' => [
+                                    [
+                                        'term' => [
+                                            'foo' => 42,
+                                        ],
+                                    ],
+                                ],
+                            ],
+                        ],
+                    ],
+                    'from' => 0,
+                    'size' => 1,
+                ],
+            ])
+            ->willReturn([
+                'hits' => [
+                    'hits' => [
+                        [
+                            '_id' => '42',
+                        ],
+                    ],
+                ],
+            ]);
 
         $model = (new Model())->resolveRouteBinding(42, 'foo');
 
-        self::assertSame($model->_id, 42);
+        self::assertSame($model->_id, '42');
     }
 
     public function testMergeCasts(): void