Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ElasticSearchEngine->performSearch result to array when the… #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert ElasticSearchEngine->performSearch result to array when the… #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Engines/ElasticSearchEngine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ private function performSearch(BaseBuilder $builder, $options = [])
$callback,
$this->elasticsearch,
$searchBody
);
)->asArray();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think same approach before but how could we be sure this callback return an object and it has asArray method?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does that mean that omitting asArray call was intentional? As in it is left up to the callback to decide what is returned?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And actually now that I think, its a callback. There's literally no way to make sure that it will return what you expect, cause ultimately the developer really can return whatever they want, and I am not aware of any way in php to enforce a return value of callback.

So I think maybe the only thing i can do, is add the appropriate type hint via annotation there?

Copy link
Contributor

@hkulekci hkulekci Jun 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, while implementing upgrade I faced same problem and could not find a proper solution and I keep it as is without asArray(). What it can be, we may use invoke method of a class instead of callback. The user can implement a callback with class. The invoke could have return type.

}

$model = $builder->model;
Expand Down