Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/video cover block #56

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feat/video cover block #56

wants to merge 9 commits into from

Conversation

stonetim
Copy link
Member

@stonetim stonetim commented Oct 14, 2024

Changes proposed in this pull request

This PR adds the video cover block extension into the kindling theme.

Closes https://app.asana.com/0/1208469116909199/1208488808572718/f

Pre-submit checklist

As the author of this pull request, I verify that:

  • I have set the target branch to main.
  • I have detailed the purpose of this Pull Request in a non-technical way.
  • I have detailed how to test the changes in the Pull Request.
  • I have detailed the functional tests required for approval.
  • I have performed a self-review of my code to ensure it is DRY and follows the team's coding standards.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have verified that my code does not introduce a debug warning in my local environment.
  • I have verified that the functional tests work in my local environment.
  • I have verified that all automated tests pass or have provided a detailed comment about why I am submitting with a failed pipeline.
  • I have verified that any dependent changes have been merged and published in downstream commits.
  • I have added a link to this Pull Request in the Asana task.
  • I have moved the Asana task to "Ready for Functional Review".
  • I have left a comment in Asana and GitHub tagging a team member with a request for `review.

Testing

How to test the changes in this pull request

Follow the steps below to test the changes in this PR.

  1. Deploy this branch to the prd environment.
  2. Navigate to https://kindlingprd.wpengine.com/video-cover-block/

Functional tests

As the functional tester for this pull request, I verify that:

  • I can add a youtube URL to the cover block using the Video URL field under video background settings in the cover blocks settings sidebar.
  • I can add in overlay in the color section of the styles sidebar and control the opacity. When updated the change is reflected on the fronted.
  • When the URL is removed the image or color that is set on the cover block is displayed as the background on the frontend.
  • I can add content (headings, paragraphs, buttons, etc) to the video cover block and it appears over the video cover block on the frontend.
  • The background video is responsive.

Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana. If all tests pass, move the task to "Ready for Code Review" in Asana and tag a team member for code review.

Code review

As the code reviewer for this pull request, I verify that:

  • All automated tests have passed.
  • The code is written (or documented) in a way that is easy to understand.
  • The code is free of obvious errors.
  • The code is free of obvious duplication.
  • The code follows our coding standards.
  • The code is sanitized or escaped appropriately for any SQL or XSS injection possibilities.

Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana or continue with the "merging" steps below.

Merging

As the individual merging this pull request, I verify that:

  • All automated tests have passed.
  • All functional tests have passed.
  • All code review tests have passed.
  • I have moved the task to "Ready to Deploy" in Asana and notified the pull request author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants