Allow translation of attachments, spoilers and polls #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to translate not only status text, but also media attachment descriptions (alt text) and poll options, a new feature introduced in 4.2.0.
This still has an issue where when translating the alt text, the images are temporarily replaced with images from the posts above. This is reset when the user scrolls. I'm not sure if this is a translation issue or an issue with reloading the media view and how to fix it.
Additionally, as the translation button is part of the TextStatusDisplayItem, it is only shown for posts containing translatable text.
Originally written for sk22#916.