Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-36025 Buttons Overlapping Content in Full Screen Mode #2769

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

jarielrrz
Copy link
Contributor

@jarielrrz jarielrrz commented Dec 3, 2024

Description:
Updated the ckeditor fullscreen module to beta10 in order to fix z-index problems.

Jira: (Skip unless you are MA staff)
DP-36025

To Test:

  • Switch to fullscreen mode on a page with the specified UI elements.
  • Verify that the Edit Actions, Add List buttons, and Paragraphs Add Wrapper are hidden.
  • Exit fullscreen mode and confirm the elements reappear as expected.

Peer Review Checklist

@tom-fleming tom-fleming temporarily deployed to Tugboat December 3, 2024 19:56 Destroyed
formatting
@tom-fleming tom-fleming temporarily deployed to Tugboat December 4, 2024 14:13 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat December 9, 2024 15:07 Destroyed
Copy link

github-actions bot commented Dec 9, 2024

Composer package changes
Prod Packages Operation Base Target
drupal/ckeditor5_fullscreen Upgraded 1.0.0-beta8 1.0.0-beta10

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

@@ -3082,26 +3082,26 @@
},
{
"name": "drupal/ckeditor5_fullscreen",
"version": "1.0.0-beta8",
"version": "1.0.0-beta10",
Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caxy/php-htmldiff v0.1.15 / composer.lock

HIGH  Strong Copyleft Licenses (GPL-2.0)

Strong Copyleft Licenses

     🎉   Fixed by commit c82f9d1 - Remove patch

updated changelog
@tom-fleming tom-fleming temporarily deployed to Tugboat December 9, 2024 15:09 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat December 10, 2024 04:30 Destroyed
@tom-fleming tom-fleming temporarily deployed to Tugboat December 11, 2024 05:54 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants