D11 - Update most depecations in custom code

changelogs/DP-35404.yml

@@ -0,0 +1,41 @@
+#
+# Write your changelog entry here. Every pull request must have a changelog yml file.
+#
+# Change types:
+# #############################################################################
+# You can use one of the following types:
+#  - Added: For new features.
+#  - Changed: For changes to existing functionality.
+#  - Deprecated: For soon-to-be removed features.
+#  - Removed: For removed features.
+#  - Fixed: For any bug fixes.
+#  - Security: In case of vulnerabilities.
+#
+# Format
+# #############################################################################
+# The format is crucial. Please follow the examples below. For reference, the requirements are:
+#  - All 3 parts are required and you must include "Type", "description" and "issue".
+#  - "Type" must be left aligned and followed by a colon.
+#  - "description" must be indented with 2 spaces followed by a colon
+#  - "issue" must be indented with 4 spaces followed by a colon.
+#  - "issue" is for the Jira ticket number only e.g. DP-1234
+#  - No extra spaces, indents, or blank lines are allowed.
+#
+# Example:
+# #############################################################################
+# Fixed:
+#  - description: Fixes scrolling on edit pages in Safari.
+#    issue: DP-13314
+#
+# You may add more than 1 description & issue for each type using the following format:
+# Changed:
+#  - description: Automating the release branch.
+#    issue: DP-10166
+#  - description: Second change item that needs a description.
+#    issue: DP-19875
+#  - description: Third change item that needs a description along with an issue.
+#    issue: DP-19843
+#
+Changed:
+  - description: D11 - Update most depecations in custom code
+    issue: DP-35404

composer.json

@@ -275,6 +275,7 @@
         "friends-of-behat/mink-debug-extension": "^2",
         "imbo/behat-api-extension": "^2.0",
         "kint-php/kint": "^5",
+        "palantirnet/drupal-rector": "^0.20.3",
         "phpspec/prophecy-phpunit": "^2",
         "previousnext/phpunit-finder": "dev-main",
         "vincentlanglet/twig-cs-fixer": "^2.5",

docroot/modules/custom/file_entity_delete/file_entity_delete.info.yml

@@ -3,6 +3,6 @@ type: module
 description: Allow deletion of individual files by priveleged editors.
 package: Custom
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 dependencies:
   - drupal:file

docroot/modules/custom/file_upload_submit/file_upload_submit.info.yml

@@ -3,4 +3,4 @@ type: module
 description: Prevent submitting node edit form while file upload in progress
 package: Custom
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11

docroot/modules/custom/mass_active_directory/mass_active_directory.info.yml

@@ -2,6 +2,6 @@ name: Mass Active Directory
 type: module
 description: Integrate with Azure AD
 package: Custom
-core_version_requirement: ^9 || ^10
+core_version_requirement: ^10 || ^11
 dependencies:
   - openid_connect

docroot/modules/custom/mass_admin_pages/mass_admin_pages.info.yml

@@ -3,6 +3,6 @@ type: module
 description: 'Custom pages for the mass_admin theme'
 package: 'Custom'
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 dependencies:
   - block

docroot/modules/custom/mass_admin_pages/src/EventSubscriber/CookieSubscriber.php

@@ -48,7 +48,7 @@ public function onKernelResponse(ResponseEvent $event) {
   /**
    * {@inheritdoc}
    */
-  public static function getSubscribedEvents() {
+  public static function getSubscribedEvents(): array {
     // Act after the finish ResponseSubscriber.
     $events[KernelEvents::RESPONSE][] = ['onKernelResponse'];
     return $events;

docroot/modules/custom/mass_admin_toolbar/mass_admin_toolbar.info.yml

@@ -2,7 +2,7 @@ name: Mass.gov admin toolbar
 type: module
 description: Provides custom styles for admin toolbar. To be used with the admin_toolbar contrib module.
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 package: Custom
 
 dependencies:

docroot/modules/custom/mass_alerts/mass_alerts.info.yml

@@ -2,7 +2,7 @@ name: Mass.gov Alerts
 type: module
 description: Provides alerts related permission control and form alterations.
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 package: Custom
 dependencies:
   - mass_caching

docroot/modules/custom/mass_analytics/mass_analytics.info.yml

@@ -2,4 +2,4 @@ name: Mass Analytics
 type: module
 description: Add new Analytics tab
 package: Custom
-core_version_requirement: ^9 || ^10
+core_version_requirement: ^10 || ^11

docroot/modules/custom/mass_auto_parents/mass_auto_parents.info.yml

@@ -2,7 +2,7 @@ name: Mass.gov Automatic Parents
 type: module
 description: Temporary module to automatically assign content parents.
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 package: Custom
 dependencies:
   - entity_hierarchy

docroot/modules/custom/mass_bigquery/mass_bigquery.info.yml

@@ -2,6 +2,6 @@ name: mass_bigquery
 type: module
 description: Queries and stores analytics data from BigQuery
 package: Custom
-core_version_requirement: ^9 || ^10
+core_version_requirement: ^10 || ^11
 dependencies:
   - views

docroot/modules/custom/mass_caching/mass_caching.info.yml

@@ -2,7 +2,7 @@ name: Mass.gov Caching Enhancements
 type: module
 description: Provides caching and invalidation improvements.
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 package: Custom
 dependencies:
   - drupal:purge

docroot/modules/custom/mass_caching/src/EventSubscriber/StaleResponseSubscriber.php

@@ -27,7 +27,7 @@ public function onKernelResponse(ResponseEvent $event) {
   /**
    * {@inheritdoc}
    */
-  public static function getSubscribedEvents() {
+  public static function getSubscribedEvents(): array {
     // Act after the FinishResponseSubscriber.
     $events[KernelEvents::RESPONSE][] = ['onKernelResponse', -18];
     return $events;

docroot/modules/custom/mass_content/mass_content.info.yml

@@ -1,7 +1,7 @@
 name: Mass.gov Example Content
 type: module
 description: Provide something to work with.
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 package: Custom
 dependencies:
   - mass_types

docroot/modules/custom/mass_content/mass_content.services.yml

@@ -13,4 +13,4 @@ services:
     weight: 200
   mass_content.image_style_warmer:
     class: Drupal\mass_content\ImageStylesWarmer
-    arguments: ['@entity_type.manager', '@image.factory','@entity_type.manager']
+    arguments: ['@entity_type.manager', '@image.factory','@entity_type.manager', '@file.validator']

docroot/modules/custom/mass_content/src/ImageStylesWarmer.php

@@ -7,6 +7,7 @@
 use Drupal\Core\Entity\EntityTypeManagerInterface;
 use Drupal\Core\Image\ImageFactory;
 use Drupal\file\FileInterface;
+use Drupal\file\Validation\FileValidator;
 
 /**
  * Defines an images styles warmer.
@@ -34,6 +35,11 @@ class ImageStylesWarmer {
    */
   protected $imageStyles;
 
+  /**
+   * @var \Drupal\file\Validation\FileValidator
+   */
+  private FileValidator $fileValidator;
+
   /**
    * Constructs a ImageStylesWarmer object.
    *
@@ -47,10 +53,11 @@ class ImageStylesWarmer {
    * @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException
    * @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException
    */
-  public function __construct(EntityTypeManagerInterface $file_storage, ImageFactory $image_factory, EntityTypeManagerInterface $image_style_storage) {
+  public function __construct(EntityTypeManagerInterface $file_storage, ImageFactory $image_factory, EntityTypeManagerInterface $image_style_storage, FileValidator $fileValidator) {
     $this->file = $file_storage->getStorage('file');
     $this->image = $image_factory;
     $this->imageStyles = $image_style_storage->getStorage('image_style');
+    $this->fileValidator = $fileValidator;
   }
 
   /**
@@ -92,7 +99,7 @@ private function validateImage(FileInterface $file): bool {
     if ($file->isPermanent()) {
       $image = $this->image->get($file->getFileUri());
       $extensions = implode(' ', $image->getToolkit()->getSupportedExtensions());
-      if ($image->isValid() && empty(file_validate_extensions($file, $extensions))) {
+      if ($image->isValid() && empty($this->fileValidator->validate($file, ['FileExtension' => ['extensions' => $extensions]]))) {
         return TRUE;
       }
     }

docroot/modules/custom/mass_content/src/Plugin/views/field/RenderedEntityMixed.php

@@ -22,7 +22,7 @@ public function render(ResultRow $values) {
     $storage = $this->entityTypeManager->getStorage($entity_type_id);
     $entity = $storage->load($values->nid);
 
-    $entity = $this->getEntityTranslation($entity, $values);
+    $entity = $this->getEntityTranslationByRelationship($entity, $values);
     $build = [];
     if (!isset($entity)) {
       return $build;

docroot/modules/custom/mass_content/tests/src/ExistingSiteJavascript/ExpandCollapseElementsTest.php

@@ -86,7 +86,7 @@ public function testAccordion(string $path, string $css_selector, ?\Closure $bef
    *     - An optional function to call before running the test case, accepting
    *       a reference to the test object.
    */
-  public function accordionDataProvider(): array {
+  public static function accordionDataProvider(): array {
     return [
       '_QAG Binder_Report Table of Contents' => [
         'report/qag-binderreport',

docroot/modules/custom/mass_content_api/mass_content_api.info.yml

@@ -2,5 +2,5 @@ name: Mass Content API
 type: module
 description: Define's REST Resources for Mass.gov content
 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^10 || ^11
 package: Custom