Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dp 29600 fix suggested page item bug #2183

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

clairesunstudio
Copy link
Contributor

@clairesunstudio clairesunstudio commented Sep 6, 2023

Fixed:

  • description: Fixed suggested page item link covering the whole page.
    issue: DP-29600

Deployed to feature 1
UAT link --> https://massgovfeature1.prod.acquia-sites.com/locations/sudbury-reservoir

@tom-fleming tom-fleming temporarily deployed to Tugboat September 6, 2023 21:18 Destroyed
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Composer package changes
Prod Packages Operation Base Target
massgov/mayflower-artifacts Changed dev-develop 7118bf2 dev-develop c7dafa9

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

composer.json Outdated
@@ -273,7 +273,7 @@
"furf/jquery-ui-touch-punch": "dev-master",
"geocoder-php/open-cage-provider": "^4.4",
"google/cloud-bigquery": "^1.25",
"massgov/mayflower-artifacts": "dev-develop",
"massgov/mayflower-artifacts": "dev-patternlab/DP-29600-fix-suggested-page-item-bug",
Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laminas/laminas-diactoros 2.14.0 / composer.json

Total vulnerabilities: 1

Critical: 0 High: 1 Medium: 0 Low: 0
Vulnerability IDSeverityCVSSFixed inStatus
CVE-2023-29530 HIGH HIGH 7.5 2.25.2 Open
Vulnerabilities scan results were updated by commit cdb1ec4

@clairesunstudio clairesunstudio marked this pull request as ready for review September 7, 2023 14:33
@tom-fleming tom-fleming temporarily deployed to Tugboat September 7, 2023 19:27 Destroyed
@clairesunstudio
Copy link
Contributor Author

Feature1 might have outdated database, use the tugboat deployment for backstop instead https://pr2183-3vun6nbjzsezoigao4l5etw4tbgim8wx.tugboatqa.com/locations/quabbin-reservoir

@tom-fleming tom-fleming temporarily deployed to Tugboat September 11, 2023 09:28 Destroyed
@@ -12760,12 +12760,12 @@
"source": {
"type": "git",
"url": "[email protected]:massgov/mayflower-artifacts.git",
"reference": "d4bffc2a73e1118d6dcef990ea421e9e54d5f83a"
"reference": "c7dafa9b3a62772394ff883e92db4354e1771870"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laminas/laminas-diactoros 2.14.0 / composer.lock

Total vulnerabilities: 1

Critical: 0 High: 1 Medium: 0 Low: 0
Vulnerability IDSeverityCVSSFixed inStatus
CVE-2023-29530 HIGH HIGH 7.5 2.25.2 Open

@tom-fleming tom-fleming temporarily deployed to Tugboat September 11, 2023 09:31 Destroyed
@arthurbaghdas arthurbaghdas enabled auto-merge (squash) September 11, 2023 09:42
@arthurbaghdas arthurbaghdas merged commit a754aef into develop Sep 11, 2023
2 checks passed
@arthurbaghdas arthurbaghdas deleted the DP-29600-fix-suggested-page-item-bug branch September 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants