Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongnan
reviewed
Jun 29, 2024
| .font(Font.Body.xsmall) | ||
| .multilineTextAlignment(.center) | ||
| .foregroundColor(Color.Icon.assistive) | ||
|
|
Comment on lines
80
to
89
| var likeButton: some View { | ||
| HStack(alignment: .center, spacing: 6) { | ||
| ResourceKitAsset.Icon.ㅋ.swiftUIImage | ||
| ResourceKitAsset.Icon.개웃겨.swiftUIImage | ||
| } | ||
| .frame(maxWidth: .infinity) | ||
| .frame(height: 46, alignment: .center) | ||
| .background(Color.Skeleton.primary) | ||
| .cornerRadius(10) | ||
| } |
There was a problem hiding this comment.
요건 따로 디자인시스템쪽으로 가는게 좋아보이네요!
다른데서도 같이 쓸꺼 같아서요
There was a problem hiding this comment.
디자인 시스템은 원래 디자이너가 구현한 부분대로만 구현하는 것이 맞아보이는데요, 해당 부분이 따로 빠져있지 않아서 그냥 구현했습니다~
Comment on lines
62
to
70
| var hashTagView: some View { | ||
| HStack(alignment: .center, spacing: 6) { | ||
| ForEach(self.meme.keywords, id: \.self) { title in | ||
| hashTag(title: title) | ||
| } | ||
| } | ||
| .frame(maxWidth: .infinity, alignment: .center) | ||
| .cornerRadius(40) | ||
| } |
| .padding(.bottom, 5) | ||
|
|
||
| hashTagView | ||
|
|
hryeong66
approved these changes
Jun 29, 2024
|
|
||
| import Kingfisher | ||
|
|
||
| struct MemeImageView: View { |
There was a problem hiding this comment.
MemeImageView 비율 조정 정책 적용해서 디자인 시스템에서 공통 컴포넌트로 사용하면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
이슈
설명
Changes 📝
Screenshot 📸
To Reviewers 🙏