feat: 현재 운영중인 QuestionSet에서 총 지급된 coin 반환 API #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaeoni
approved these changes
Sep 21, 2024
| @@ -59,6 +59,14 @@ class CoinController( | |||
| .let { DojoApiResponse.success(it) } | |||
| } | |||
|
|
|||
| @GetMapping("/solved-pick") | |||
There was a problem hiding this comment.
총 지급된 코인 반환을 의미하는 api인데 path만 보면 해결된 픽(?) 이라는 의미로 읽혀요! 총 지급된 코인의 합을 내린다는 의미를 좀 더 담아보면 어떨까요~?
There was a problem hiding this comment.
현재 컨트롤러에 @RequestMapping("/coin") 요렇게 되어있어서 solvedPick 만 붙여봤습니다!
말씀하신대로 "현재 운영중인 질문지"를 내포해볼게요~
xonmin
approved these changes
Sep 21, 2024
| @@ -76,4 +98,8 @@ class DefaultCoinUseCase( | |||
| return membersService.findByFullNameAndPlatform(fullName, platform) | |||
| } | |||
| } | |||
|
|
|||
| companion object { | |||
| private const val PROVIDE_COIN_BY_COMPLETE_PICK = 20 | |||
There was a problem hiding this comment.
결국 해당 값도 한 문제 풀면 제공되는 값이 pick api 호출될 떄마다 쓰이는 값이랑 동일할 텐데 yaml 내 값으로 변수 선언해두고 바인딩해서 쓰는게 좋을 것 같아요
There was a problem hiding this comment.
정책적으로 한 문제당 20개로 정했었나요!?
넵 그렇게 전달받았습니다.
결국 해당 값도 한 문제 풀면 제공되는 값이 pick api 호출될 떄마다 쓰이는 값이랑 동일할 텐데 yaml 내 값으로 변수 선언해두고 바인딩해서 쓰는게 좋을 것 같아요
아하 그렇네요 바인딩하는 방식으로 수정하겠습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[add] pr template작업 내용
현재 운영중인 QuestionSet에서 본인의 질문지 중 픽한 개수만큼 지급된 코인을 반환하는 API입니다.
비고 (첨부자료)