Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin feature find player subset zones #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hugo3m
Copy link
Contributor

@hugo3m hugo3m commented May 31, 2024

I started implementing a function FindZoneId to find to which zone of the world a point belongs too. But during my testing generateWorld_Grid had a different behavior that I would expect. I confirm my ideas by implementing InFront for the Plane to determine if a point is in front or behind a plane, according to the normal direction.

I found out generateWorld_Grid was generating box towards the negative values of the axis, which was not the behavior I would expect. I proposed changes in the pull request.

@hugo3m
Copy link
Contributor Author

hugo3m commented May 31, 2024

I also validated my idea by testing the FindZoneIdfunction which seems behaving as I would expect now that I changed generateWorld_Grid

@hugo3m
Copy link
Contributor Author

hugo3m commented May 31, 2024

PS: I am aware of the tab indent problem but surprisingly it does not seem like my git wants to see changes since I fixed it.

@hugo3m hugo3m marked this pull request as ready for review May 31, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant