Change posts feature's PDF processor to pdf2pic due to unfixed bugs in pdf-img-convert package #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pdf-img-convert module - Remove pdf-img-convert from package.json, add pdf2pic - Add RUN commands in posts Dockerfile to install needed binaries - Replace pdf-img-convert configuration in file-converter and pdf-preview files with pdf2pic configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the pdf-img-convert package is being used for converting PDF files to images. This worked well until certain bugs were introduced into the package. They have not yet been fixed. (See here and here](ol-th/pdf-img-convert.js#43).)
As a result, the pdf-img-convert package is being replaced with the pdf2pic package. Although the latter works, it is noticeably slower and requires certain binaries to be installed. If the pdf-img-convert package is fixed, the posts feature will go back to using pdf-img-convert.
This PR introduces the following changes: