-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: make jj split more explicit about filesets #5097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I really like how simple this looks, we've only had inconclusive discussions around multi-splitting in Discord. This also resurfaces #3879/#3549 (comment) which hasn't gotten any valuable traction.
4c36266
to
4205ec0
Compare
--second
to split
commandThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
We need to know how much the feature is actually needed as by Martin.
This seems like a great change to me. I was also personally unaware that In principle: I suppose a user might check the help text and be a little put off or scared by talk of "filesets" instead of just "files" or "paths". But I'm optimistic they'll have seen enough example usage to just ignore what they don't understand and pass paths normally, and treat "filesets" as a black box abstraction if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think every command that uses parse_file_patterns()
could use the same update. I can try to follow up with that.
Maybe we should update |
Checklist
If applicable:
CHANGELOG.md