Back out 89d57ffb: "build: add rust-toolchain.toml"
#5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backs out commit 89d57ff. This is causing a CI failure because we can't build musl binaries, presumably because the rust-toolchain file overriding the chosen musl toolchain for some reason. Backout until we can reapply a proper fix. Signed-off-by: Austin Seipp <[email protected]>
arxanas
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks for fixing this.
- Do you understand why the job is failing? It's not clear to me why setting the Rust toolchain would affect this; surely we can build a release on our MSRV as well as latest
stable? - Do you know if there's a way to test/trigger the build-releases job as part of a PR to validate this behavior in the future?
|
Yeah, we can build binaries on PRs to catch this in the future, I might submit a follow up change for that even if they mostly won't be used. As for why it's failing, no, I don't yet have a fully clear idea, but I also haven't isolated it to whether it's just a problem with dtolnay/rust-toolchain, or the existince of the .toml file is overriding something. I might hopefully have some time this weekend to do so... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backs out commit 89d57ff.
This is causing a CI failure because we can't build musl binaries, presumably because the rust-toolchain file overriding the chosen musl toolchain for some reason. Backout until we can reapply a proper fix.
Checklist
If applicable:
CHANGELOG.md